Fix: Voting premium removes the branding footer without unlocking a c… - #147
Merged
Conversation
…ustom one
`BuildCustomEmbed` treated "not free" as "may use a custom footer", so a voting server got both no branding *and* its own footer. `branding bool` becomes `FooterPolicy{ShowBranding, AllowCustom}`:
- no premium → branding footer
- voting premium → no footer at all
- paid premium → custom footer
BenHall-1
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pairs with the dashboard PR gating the embed footer behind Premium.
BuildCustomEmbedtreated "not free" as "may use a custom footer", so a voting server got both no branding and its own footer.branding boolbecomesFooterPolicy{ShowBranding, AllowCustom}:FooterPolicyForContextresolves it fromGetTierByGuildIdWithSource, checking forEntitlementSourceVoting. One extra Redis-cached read per welcome message, against the entryPremiumTier()already populated; a lookup error falls back to the paid case so an outage can't strip a paying server's footer.Tag callers pass
{AllowCustom: true}— tags are never branded and keep theirs.Type of Change
Checklist